Attribute Checking script

[spydermann93]

Hello,

I'm trying to create a code to check if a character is not flying, but whatever I try does not work.

Does anybody have any suggestions?

What I'm trying to get to happen is whenever a character is not flying, they get a boost in stats.

[Epimethee]

You just need to use FFX's MLOG_IsFlying() (you can refer to the FFX manual). The code for the various flight attributes in ffx.py should give you plenty of examples.

Have fun!

[spydermann93]

Ok, I'm really stumped, here.

Here's my code:

Code Select Expand

def initsuperspeed5(char,update=0,remove=0):
    superspeed(char,9,update,remove)

def superspeed(char,grade,update,remove):
    if update==0:
        if remove == 0:
            mlogreader.cancelAnimationCallbackSink(char,'ffx.superspeedupdate',persistent=1)
            FFX_ObjectSetAttr(char,'superspeed',1)
            FFX_ObjectSetAttr(char,'superspeedgrade',grade)
        else:
            mlogreader.cancelAnimationCallbackSink(char,'ffx.superspeedupdate')
            FFX_ObjectSetAttr(char,'superspeed',0)

def superspeedupdate(event):
    char=event.object
    if Object_Exists(char)==0:
        return
    RegTimer('superspeedupdate',1,0,char)
    if Object_IsAlive(char)==0: ###!
        return
    if Object_GetAttr(char,'speed')>9:
        return
    if FFX_ObjectGetAttr(char,'tkFlightTarget',0)==1:# added to play well with TK Group Flight
        return
    maxEP=Object_GetAttr(char,'maxEnergyPoints')
    ep=Object_GetAttr(char,'energyPoints')
[b]if hasAttribute(char,'humanrocket'):#[/b]
if maxEP > 0:
            speed=Object_GetAttr(char,'templateSpeed')
Object_SetAttr(char,'speed',speed)
FFX_ObjectSetAttr(char,'baseSpeed',speed)
return

    else:   # no HUMAN ROCKET attribute
        if maxEP > 0:
            speed=FFX_ObjectGetAttr(char,'superspeedgrade')
Object_SetAttr(char,'speed',speed)
FFX_ObjectSetAttr(char,'baseSpeed',speed)
return


I cannot see what's wrong.

The line with the "[ b ]" tag around it (it's not actually part of the code) is the line that the game keeps telling me is wrong.

What I'm trying to say is if the humanrocket attribute is applied, he attribute will set speed back to normal, and when it's absent, speed will be increased again.

I've tried all sorts of methods, but I cannot get this to work.

[stumpy]

I'm not sure exactly what how you want the interaction of your attribute with HUMAN ROCKET to work. I suspect that running a heartbeat script (which seems to be what is going on above) is not the most efficient way to do things. But, I'll offer a couple ideas on that in a minute.

First, the error you are getting on the [ b ] line is not clear to me. Initially, it looks like the indentation is wrong because of mixed tabs and spaces, but that may just be some artifact of the pasted code. Make sure that the indentation is either all spaces or all tabs. Don't mix them! Just to double-check, the if hasAttribute line should be indented to the same level as the ep= line above it. If the issue isn't indentation, post the full error code and we may recognize the problem.

Second, cancelAnimationCallbackSink() only takes two arguments, but you are calling it with three. That will cause an error at some point, but it may not show up right away, which is bad since it won't pop up until you've forgotten how this code works. ;-)

And, if you are running superspeedupdate() as a heartbeat script, then you probably want a RegTimer() call in that superspeed() function. At least, I can't see where you are registering any animation event handlers, so there's no reason to cancel any. And, it seems like you probably want a call to MLOG_IsFlying() in there somewhere, to check if the character is actually flying, but I could be unclear about what you are trying to do there.

To the broader point mentioned up top, another approach to this is to use the RegFlight sinks instead of heartbeat scripts. That way, they only run when needed, instead of running every second and checking if they need to change something. For instance, assume you wanted a character to get a boost when he isn't flying that goes away if he starts flying. The pseudocode for that might look something like

Code Select Expand

def superspeed(char,grade,update,remove):
    if update==0:
        if remove == 0:
            # if he's not flying now, give him the boost
            if not mlogreader.MLOG_IsFlying(char):
                superspeedboost(char)
            # register handlers for when he starts to fly and stops flying
            mlogreader.RegFlightStop(char,'ffx.superspeedboost',persistent=1)
            mlogreader.RegFlightStart(char,'ffx.superspeedunboost',persistent=1)
            FFX_ObjectSetAttr(char,'superspeed',1)
            FFX_ObjectSetAttr(char,'superspeedgrade',grade)
        else:
            # remove any boost
            superspeedunboost(char)
            mlogreader.cancelAnimationCallbackSink(char,'ffx.superspeedboost')
            mlogreader.cancelAnimationCallbackSink(char,'ffx.superspeedunboost')
            FFX_ObjectSetAttr(char,'superspeed',0)
           
def superspeedboost(event):
    if isinstance(event,types.StringType):  # called with just the character name
        char = event
    else:
        char = event.object                 # called from an event sink
    if FFX_ObjectGetAttr(char,'superspeedboosted'):
        return  # already boosted
    # DO BOOSTING HERE
    FFX_ObjectSetAttr(char,'superspeedboosted',1)  # note that the char is boosted

def superspeedunboost(event):
    if isinstance(event,types.StringType):  # called with just the character name
        char = event
    else:
        char = event.object                 # called from an event sink
    if not FFX_ObjectGetAttr(char,'superspeedboosted'):
        return  # already not boosted
    # REMOVE BOOSTING HERE
    FFX_ObjectSetAttr(char,'superspeedboosted',0)  # note that the char is not boosted

That isn't tested code or anything and it doesn't change any of the stats; that goes where the comments in all caps are. It's just to give an outline of using the flight sinks and the bookkeeping.

[spydermann93]

Hello Stumpy,

What I was trying to accomplish is something along the lines of human rocket, but for the ground.

I'm trying to get a code where instead of having to write multiple versions of the same three functions, I can do something like the human rocket attribute's method of calling a speed grade and using that as the character's speed.

The thing that I was trying to do with the Human Rocket attribute (of which I failed miserably at) was to see if a character had the attribute and cancel out the character's speed boost when it was applied.  But I think that this MLOG_IsFlying(): call is better than what I was trying to accomplish.

I'm completely new to Python, so I have little to no idea what I am doing. I can see that attributes are just simply the code calling for something; seeing if it applies; and acting out accordingly.

[stumpy]

If I understand correctly, you are writing an attribute that is the compliment of HUMAN ROCKET, sort of a HUMAN ROCKETSLED. It adds speed when the character is not flying, rather than when he is. That's what I was assuming before, so the code outline I posted last time may still be helpful to you. If I am not understanding the attribute correctly, maybe have another shot at describing it.

FWIW, MLOG_IsFlying() is a handy function (there are lots of them in the mlogreader module) and a perfectly legit way to do the sort of thing you are doing is by using a heartbeat script that calls it. For our purposes, a heartbeat script is one that runs periodically (every so many seconds) to test if a condition is true (like "has the character changed from flying to being on the ground"?) and then do something if it is. There are many situations in which that is the only way to have something happen when a condition is met.

However, there are some disadvantages of that approach. A few: First, such code creates an extra loop that is running all the time, even when it has nothing to do (such as when the character spends a while on  the ground or a while flying) and that can add to general lag in the game. Second, heartbeat scripts can only detect the event when they are called, so there may be a delay in the response to the condition of up to the heartbeat period. In other words, the character starts flying really fast and a second later he slows down. Of course, having a short period (a "fast heartbeat") to deal with that second issue is fine, but that exacerbates the first issue. A third and potentially more complicated issue is what if multiple state changes take place within the space of one heartbeat?

The other approach is to take advantage of event sinks and event handlers. An event sink is something that registers a function (a handler) so that it will run only when a certain event is detected, such as when a character has stopped flying. Those event sinks are especially useful for detecting changed states, such as a transition from flying to not fly. The functions that need to run when the condition is met only run when it is and the programmer gets the benefit of quicker response to the event. In the case of the animation sinks, I think that they are run within 0.1 seconds of the detected state.

In essence, running a heartbeat can be a little like having a silent phone where one checks to see if someone has called by picking up the phone every second: If someone's there, start talking to them. Using event sinks is more along the lines of installing a device (a ringer) that alerts you when someone is on the line so you can go about ignoring the phone unless you hear it ring.

I didn't provide very good pseudo code last time. It was too close to actual python code. Think about the logic of the attribute functions this way

Code Select Expand

superspeed function:
    If we aren't removing the attribute:
        TEST: if char is not already flying, then call superspeedboost to give him the boost.
        REGISTER SINK: If the character starts flying at some point, call superspeedunboost to remove the boost
        REGISTER SINK: If the character stops flying at some point, call superspeedboost to give him  the boost
        Do some bookkeeping to make sure FFX knows the attribute is active
    If we are removing the attribute:
        Call superspeedunboost to remove the boost
        Cancel the sink that calls superspeedunboost when the character starts flying
        Cancel the sink that calls superspeedboost when the character stops flying
        Do some bookkeeping to make sure FFX knows the attribute is inactive
superspeedboost function:
    Check a variable to be sure the character's speed isn't already boosted by this function
    Boost the character's speed
    Set the variable to mark that the character has been boosted by this function
superspeedunboost function:
    Check a variable to be sure the character's speed is already boosted by the superspeedboost function
    Boost the character's speed
    Reset the variable to mark that the character's superspeedboost has been removed
Maybe that is more helpful.

[spydermann93]

This has helped my understanding quite a lot.

I'll see what I can come up with and report to you sometime in the future (I have a lot of test runs to go through )

Thank you for all of your help so far, Stumpy.

It is very much appreciated.

And yes, you hit the nail right on the head with what I am trying to do. My apologies for not being so clear the first time.

[spydermann93]

Just for a quick question:

Are attributes typically lead by the prefix "init"?

I ask because that's what it seems like to me.

Also, does the function (I'm unsure if that's the proper term for it) "if" always need either a "return" or "else" function to end it? That's what it seems like to me.

[spydermann93]

Ok, this is what I have:

Code Select Expand

def initsuperspeed5(char,update=0,remove=0):
    superspeed(char,19,update,remove)

def superspeed(char,grade,update,remove):
    if update==0:
        if remove == 0:
            if not mlogreader.MLOG_IsFlying(char):
                superspeedboost(char)
            mlogreader.regFlightStop(char,'ffx.superspeedboost',persistent=1)
            mlogreader.regFlightStart(char,'ffx.superspeedunboost',persistent=1)
            FFX_ObjectSetAttr(char,'superspeedgrade',grade)
            FFX_ObjectSetAttr(char,'superspeed',1)
        else:
            superspeedunboost(char)
            mlogreader.cancelAnimationCallbackSink(char,'ffx.superspeedboost')
            mlogreader.cancelAnimationCallbackSink(char,'ffx.superspeedunboost')
            FFX_ObjectSetAttr(char,'superspeed',0)

def superspeedboost(event):
    if isinstance(event,types.StringType):  # called with just the character name
        char = event
    else:
        char = event.object                 # called from an event sink
    if not FFX_ObjectGetAttr(char,'superspeedboosted'):
        return  # already boosted
    speed=FFX_ObjectGetAttr(char,'superspeedgrade')
    Object_SetAttr(char,'speed',speed)
    FFX_ObjectSetAttr(char,'baseSpeed',speed)
    FFX_ObjectSetAttr(char,'superspeedboosted',1)

def superspeedunboost(event):
    if isinstance(event,types.StringType):  # called with just the character name
        char = event
    else:
        char = event.object                 # called from an event sink
    if FFX_ObjectGetAttr(char,'superspeedboosted'):
        return  # already not boosted
    speed=FFX_ObjectGetAttr(char,'superspeedgrade')
    Object_SetAttr(char,'speed',speed)
    FFX_ObjectSetAttr(char,'baseSpeed',speed)
    FFX_ObjectSetAttr(char,'superspeedboosted',0)
#    FFX_ObjectSetAttr(char,'baseSpeed',speed)


This time, the code actually runs. However, there are two major problems:

1) The speed boost only kicks in AFTER my character has taken flight. Once he lands, the speed boost works. Also, it applies during flight as well.

2) Whenever I use the Human Rocket attribute, it would seem that the speed boost is over-ruled. My character's human rocket attribute works, but when he lands, he does not get a speed boost.

[stumpy]

I don't know how much of the issue this is, but part of the problem is that the call to the boost function if the char is initially not flying takes place before the speed grade is set. The version below should remedy that. I've also added a couple print statements that may help debug what's going on.

Code Select Expand

def initsuperspeed5(char,update=0,remove=0):
    superspeed(char,19,update,remove)

def superspeed(char,grade,update,remove):
    if update==0:
        if remove == 0:
            mlogreader.regFlightStop(char,'ffx.superspeedboost',persistent=1)
            mlogreader.regFlightStart(char,'ffx.superspeedunboost',persistent=1)
            FFX_ObjectSetAttr(char,'superspeedgrade',grade)
            FFX_ObjectSetAttr(char,'superspeed',1)
            if not mlogreader.MLOG_IsFlying(char):
                superspeedboost(char)
        else:
            superspeedunboost(char)
            mlogreader.cancelAnimationCallbackSink(char,'ffx.superspeedboost')
            mlogreader.cancelAnimationCallbackSink(char,'ffx.superspeedunboost')
            FFX_ObjectSetAttr(char,'superspeed',0)

def superspeedboost(event):
    if isinstance(event,types.StringType):  # called with just the character name
        char = event
    else:
        char = event.object                 # called from an event sink
    print "superspeedboost(%s) called: FFX_ObjectGetAttr(%s,'superspeedboosted')==%d Object_GetAttr(%s,'speed')==%d" % (repr(event),repr(char),FFX_ObjectGetAttr(char,'superspeedboosted'),repr(char),Object_GetAttr(char,'speed'))
    if not FFX_ObjectGetAttr(char,'superspeedboosted'):
        return  # already boosted
    speed=FFX_ObjectGetAttr(char,'superspeedgrade')
    Object_SetAttr(char,'speed',speed)
    FFX_ObjectSetAttr(char,'baseSpeed',speed)
    FFX_ObjectSetAttr(char,'superspeedboosted',1)

def superspeedunboost(event):
    if isinstance(event,types.StringType):  # called with just the character name
        char = event
    else:
        char = event.object                 # called from an event sink
    print "superspeedunboost(%s) called: FFX_ObjectGetAttr(%s,'superspeedboosted')==%d Object_GetAttr(%s,'speed')==%d" % (repr(event),repr(char),FFX_ObjectGetAttr(char,'superspeedboosted'),repr(char),Object_GetAttr(char,'speed'))
    if FFX_ObjectGetAttr(char,'superspeedboosted'):
        return  # already not boosted
    speed=FFX_ObjectGetAttr(char,'superspeedgrade')
    Object_SetAttr(char,'speed',speed)
    FFX_ObjectSetAttr(char,'baseSpeed',speed)
    FFX_ObjectSetAttr(char,'superspeedboosted',0)
#    FFX_ObjectSetAttr(char,'baseSpeed',speed)

I don't know if that will help with the other issues. It might be useful to post your script.log to see if any errors are showing up that relate to this.

[stumpy]

Are attributes typically lead by the prefix "init"?

I ask because that's what it seems like to me.

Yes, by convention in FFX, the initialization function is named init + the name (as seen in FFEdit's Attributes tab) of the attribute.

Also, does the function (I'm unsure if that's the proper term for it) "if" always need either a "return" or "else" function to end it? That's what it seems like to me.

In python, the if keyword need not be followed by an else or a return. For example, the if block starting with if not mlogreader.MLOG_IsFlying(char): in the code above has neither of the other keywords in it (though the surrounding conditional forms an if-else block).

And, in fact, python functions need not have a return in them anywhere (making such functions what are sometimes called procedures in other languages). However, though we don't use it much in FF scripting, a function will return a None value if it isn't exited with an explicit return statement. For example

Code Select Expand

>>> def PrintBob():
... print "bob"
...
>>> x=PrintBob()
bob
>>> print x
None
>>>

[spydermann93]

Here's what the script.log tells me:

Code Select Expand

try to spawn custom_vil_0
sk.SpawnEnemy: energy for _skcustom_vil_001 (misc thug (gun)) changed from 9 to 2
MLOG_Init(keepRunningModules=0): starting up
mlogreader.MLOG_Init: current mission = 'MP_CITY'
initialising FFX: skirmish=1
numberStr=44
storing hero_0: id_1,-44
! GetMapInfo
initialising FFQ_initialiseExtras()
FFX_UpdateSun: getting default sun
FFX_UpdateSun: setting = (-140.0, 70.0, 1.0, 0.800000011921, (0.699999988079, 0.600000023842, 0.600000023842))
addArrow _sk_arrow _skcustom_vil_001 0 0
initAttribsForChar: working on _skcustom_vil_001 (misc thug (gun))
initAttribsForChar (misc thug (gun)): looking at attribute unheroic
initAttribsForChar: working on hero_0 (1test)
initAttribsForChar (1test): looking at attribute superspeed5
execInitAttrib: init superspeed5 attribute
    on hero_0 of template custom_template_44 (1test)
superspeedboost('hero_0') called: FFX_ObjectGetAttr('hero_0','superspeedboosted')==0 Object_GetAttr('hero_0','speed')==9
initAttribsForChar (1test): looking at attribute flier
Plugin 'freeroam_keepbuildingdamage' OnPostInit() called
Plugin 'm25ai_lowjumper' has no OnPostInit()
Plugin 'm25ai_realitymanipulation' has no OnPostInit()
Plugin 'cutscene_power' has no OnPostInit()
Plugin 'm25enc_opendoor' has no OnPostInit()
Plugin 'm25enc_simplechoice' has no OnPostInit()
superspeedunboost(<mlogreader.PseudoAnimationEvent instance at 1421ec28>) called: FFX_ObjectGetAttr('hero_0','superspeedboosted')==0 Object_GetAttr('hero_0','speed')==9
superspeedboost(<mlogreader.PseudoAnimationEvent instance at 1421ecb8>) called: FFX_ObjectGetAttr('hero_0','superspeedboosted')==0 Object_GetAttr('hero_0','speed')==19


Now, from what I see, the speedunboost does not add the speed boost (which is expected as it removes the attribute), but after being speed boosted, it is not ever recalled.

[stumpy]

Sorry, dumb error on my part. The logic in the test for whether the toon is already boosted or not is reversed in the boost and unboost functions. Try the following.

Code Select Expand

def initsuperspeed5(char,update=0,remove=0):
    superspeed(char,19,update,remove)

def superspeed(char,grade,update,remove):
    if update==0:
        if remove == 0:
            mlogreader.regFlightStop(char,'ffx.superspeedboost',persistent=1)
            mlogreader.regFlightStart(char,'ffx.superspeedunboost',persistent=1)
            FFX_ObjectSetAttr(char,'superspeedgrade',grade)
            FFX_ObjectSetAttr(char,'superspeed',1)
            if not mlogreader.MLOG_IsFlying(char):
                superspeedboost(char)
        else:
            superspeedunboost(char)
            mlogreader.cancelAnimationCallbackSink(char,'ffx.superspeedboost')
            mlogreader.cancelAnimationCallbackSink(char,'ffx.superspeedunboost')
            FFX_ObjectSetAttr(char,'superspeed',0)

def superspeedboost(event):
    if isinstance(event,types.StringType):  # called with just the character name
        char = event
    else:
        char = event.object                 # called from an event sink
    print "superspeedboost(%s) called: FFX_ObjectGetAttr(%s,'superspeedboosted')==%d Object_GetAttr(%s,'speed')==%d flying==%d" % (repr(event),repr(char),FFX_ObjectGetAttr(char,'superspeedboosted'),repr(char),Object_GetAttr(char,'speed'), mlogreader.MLOG_IsFlying(char))
    if FFX_ObjectGetAttr(char,'superspeedboosted'):
        return  # already boosted
    speed=FFX_ObjectGetAttr(char,'superspeedgrade')
    Object_SetAttr(char,'speed',speed)
    FFX_ObjectSetAttr(char,'baseSpeed',speed)
    FFX_ObjectSetAttr(char,'superspeedboosted',1)

def superspeedunboost(event):
    if isinstance(event,types.StringType):  # called with just the character name
        char = event
    else:
        char = event.object                 # called from an event sink
    print "superspeedunboost(%s) called: FFX_ObjectGetAttr(%s,'superspeedboosted')==%d Object_GetAttr(%s,'speed')==%d flying==%d" % (repr(event),repr(char),FFX_ObjectGetAttr(char,'superspeedboosted'),repr(char),Object_GetAttr(char,'speed'), mlogreader.MLOG_IsFlying(char))
    if not FFX_ObjectGetAttr(char,'superspeedboosted'):
        return  # already not boosted
    speed=FFX_ObjectGetAttr(char,'superspeedgrade')
    Object_SetAttr(char,'speed',speed)
    FFX_ObjectSetAttr(char,'baseSpeed',speed)
    FFX_ObjectSetAttr(char,'superspeedboosted',0)
#    FFX_ObjectSetAttr(char,'baseSpeed',speed)


The script.log from that might make more sense.

BTW, I would test this first using a character without HUMAN ROCKET (or other speed-influencing FFX attributes), just to minimize confusion about attributes that change speed.

[spydermann93]

Ok, so this is what the script file says when using superspeed with Flight (no human rocket):

Code Select Expand

try to spawn custom_vil_0
sk.SpawnEnemy: energy for _skcustom_vil_001 (misc thug (bat)) changed from 9 to 2
MLOG_Init(keepRunningModules=0): starting up
mlogreader.MLOG_Init: current mission = 'MP_CITY'
initialising FFX: skirmish=1
numberStr=44
storing hero_0: id_1,-44
! GetMapInfo
initialising FFQ_initialiseExtras()
FFX_UpdateSun: getting default sun
FFX_UpdateSun: setting = (-140.0, 70.0, 1.0, 0.800000011921, (0.699999988079, 0.600000023842, 0.600000023842))
addArrow _sk_arrow _skcustom_vil_001 0 0
initAttribsForChar: working on _skcustom_vil_001 (misc thug (bat))
initAttribsForChar (misc thug (bat)): looking at attribute unheroic
initAttribsForChar: working on hero_0 (1test)
initAttribsForChar (1test): looking at attribute superspeed5
execInitAttrib: init superspeed5 attribute
    on hero_0 of template custom_template_44 (1test)
superspeedboost('hero_0') called: FFX_ObjectGetAttr('hero_0','superspeedboosted')==0 Object_GetAttr('hero_0','speed')==9 flying==0
initAttribsForChar (1test): looking at attribute flier
Plugin 'freeroam_keepbuildingdamage' OnPostInit() called
Plugin 'm25ai_lowjumper' has no OnPostInit()
Plugin 'm25ai_realitymanipulation' has no OnPostInit()
Plugin 'cutscene_power' has no OnPostInit()
Plugin 'm25enc_opendoor' has no OnPostInit()
Plugin 'm25enc_simplechoice' has no OnPostInit()
superspeedunboost(<mlogreader.PseudoAnimationEvent instance at e1d5e88>) called: FFX_ObjectGetAttr('hero_0','superspeedboosted')==1 Object_GetAttr('hero_0','speed')==19 flying==1
superspeedboost(<mlogreader.PseudoAnimationEvent instance at e1d5de0>) called: FFX_ObjectGetAttr('hero_0','superspeedboosted')==0 Object_GetAttr('hero_0','speed')==19 flying==0

Now, when in use with the standard Flight attribute, the speed boost works like a charm; the character gains the trait without having to fly first.

However, here are the two issues:

1) The character's speed is not placed back to their standard speed while flying

2) the Human Rocket attribute still overrides the speed boost after the character has landed.

[stumpy]

It looks like the problem (still not examining interactions with HUMAN ROCKET) is that the unboost code never sets the speed back to the template speed, assuming that's where you want it to go. It is still setting the speed to the ugrade speed. If you change that, then he should slow down again when flying. In other words, in the superspeedunboost function, maybe changing

Code Select Expand

    speed=FFX_ObjectGetAttr(char,'superspeedgrade')
to something like

Code Select Expand

    speed=Object_GetAttr(char,'templateSpeed')
I am assuming that is where you want the speed to return to when he flies. I have no idea how that will interact with other speed-altering attributes like FAST FLYER.

[spydermann93]

It looks like the problem (still not examining interactions with HUMAN ROCKET) is that the unboost code never sets the speed back to the template speed, assuming that's where you want it to go. It is still setting the speed to the ugrade speed. If you change that, then he should slow down again when flying. In other words, in the superspeedunboost function, maybe changing

Code Select Expand

    speed=FFX_ObjectGetAttr(char,'superspeedgrade')
to something like

Code Select Expand

    speed=Object_GetAttr(char,'templateSpeed')
I am assuming that is where you want the speed to return to when he flies. I have no idea how that will interact with other speed-altering attributes like FAST FLYER.

I thought about that, but I was following your suggestions to the letter in your code-explanation. I was unsure if it was a typo or if it was what you actually meant for me to do. My fault for not trying it, though

The issue with Human Rocket, I think, is that it replaces the speed reading for a character that the script calls when basing the boost. I'll look more into how to resolve this.

Is there anyway to have the speedboost script run before the fast flier script? I'm having a feeling that it's just the order in which they are called, not so much as replacing one another (though I still think that that is an issue that I need to look at).

[spydermann93]

Ok, after testing, the superspeed boost works perfectly well with Flier (no humanrocket).

However, the human rocket attribute is still causing issues. The character reverts back to normal speed after flight.

I'm curious; would creating a copy of humanrocket that calls for the speedboost rather than the template speed work?

[stumpy]

Last question first, I am not sure that having HUMAN ROCKET share the SUPER SPEED speed boost (and unboost) function would really help here. It seems that attribute is already doing something very like what you are doing here and I suspect that some (possibly tricky) extra logic would be needed to let them both use the same boost functions and not confuse each other. It could be done, but it may not be the first thing to try.

I am guessing that a character with both HUMAN ROCKET and your SUPER SPEED attribute may suffer from a race condition. That is, both attributes call functions when flight starts and stops, but what ends up happening depends on which function fires first, which we can't know. (This isn't quite an archetypal race condition, since we the order in which these two functions are run is actually predictable, but it's sufficiently complicated that we don't want to bother determining which will run first.) For example, I am pretty sure that the flight-stop sink that HUMAN ROCKET uses to lower speed when the toon lands is firing after the one that SUPER SPEED uses to raise the speed when he lands. Thus, he ends up with the speed that HUMAN ROCKET thinks is his proper ground speed when he's not flying.

Regardless of exactly how it happens, the fact that these two attributes trip each other up is the basic problem. Now, the best scripting solution is probably to make each attribute's script a bit more bulletproof, so that it does the right thing, even if some other attribute is affecting the character's speed. The slightly easier scripting solution is to make a specific check for other speed-altering attributes (that is, have SUPER SPEED check for HUMAN ROCKET) and do something special to accommodate that specific other attribute. The latter solution can run into trouble when some other attribute that wasn't accommodated (like FAST FLYER) alters the character's speed. And, it has to be done for the functions of each speed-altering attribute, so the code for all of the function grows with any extra speed-changer and the whole thing can get very hairy.

And, the best solution may not involve scripting at all and instead streamlining the character design. That is, rather than there being a character who never operates at his base speed, just pick one base speed for that character that is either his non-flight speed or his flight speed. A character that has one speed when not flying and another when flying should have one of those speeds as his actual character speed. In other words, if a toon is to have speed 5 on the ground and speed 8 in the air, then make his character speed 5 and only give him the flight-speed-boosting attribute. Or, if he is supposed to have an 8 running speed and a 5 flight speed, then make his base speed 5 and only give him the ground-speed-boosting attribute. That way, there aren't several scripts all trying to do things that change the same stat and there is less likelihood of one (or more) of them not playing well with the others.

Anyway, here's the sketch of a bulletproofing approach: In the boost function, check if the toon's current speed is the template speed before making any changes. If it is, then that should indicate that the other speed-altering attributes are done with him and it's safe to muck with his speed again. If it's not, then use RegTimer() to call the boost function after a short delay (maybe 0.1 sec). Then, in the unboost function, do the same thing in reverse, checking that the toon is at the boosted speed before unboosting him, and delaying if he isn't. (It may be necessary to bulletproof the HUMAN ROCKET scripts in the same way, but just try doing yours first.)

The potential hazard to that approach is that the toon may not get back to his normal speed for some reason, so I would keep a close eye on the logs and make sure that these functions are not firing a zillion times. If they are, then it's likely that the speed isn't getting back to where you are expecting to.

[spydermann93]

Yeah, looks like I have some reformulating to do. I'm going to mess with the scripts on my own and see where that leads, but I'm sure I'll find a pretty decent method sooner or later.

Thank you very much for all of your help, Stumpy! I greatly appreciate all of your help in this.